Allow ds.NewTransaction() to return an error #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Sep 24, 2018
Stebalien
approved these changes
Sep 24, 2018
bigs
approved these changes
Sep 25, 2018
magik6k
approved these changes
Sep 26, 2018
|
This is API change, so in theory, it should be go-datastore 4.0.0. From another side, it is just a change in |
|
@Kubuxu had the very same dilemma. Pragmatically it should be a major bump, but I don't want to pollute that namespace for such a narrowly-scoped change. All downstream DS are being updated in lockstep. Any gripes with keeping it a minor? |
|
SGWM |
|
feel free to merge these all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.