This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
feat: plumb through context changes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guseggert
force-pushed
the
feat/context
branch
from
f85899f
to
9cda79b
Compare
petar
approved these changes
Nov 10, 2021
| @@ -133,7 +134,7 @@ func list(fs *Filestore, verify bool, key mh.Multihash) *ListRes { | |||
|
|
|||
| func listAll(fs *Filestore, verify bool) (func() *ListRes, error) { | |||
| q := dsq.Query{} | |||
| qr, err := fs.fm.ds.Query(q) | |||
| qr, err := fs.fm.ds.Query(context.Background(), q) | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
There was a problem hiding this comment.
Either the lambda returned below or ListAll() should take a context. Probably ok to leave it like this for now.
|
This is wrong b/c I didn't realize that go-ipfs consumes go-filestore@v0.0.3 whereas this is building on the breaking changes introduced in v1.0.0, so I need to backport this. |
|
We still need to have a v1 version of this for use in places like lotus |
aschmahmann
suggested changes
Nov 19, 2021
guseggert
force-pushed
the
feat/context
branch
from
85a65a1
to
9537994
Compare
guseggert
changed the title
guseggert
force-pushed
the
feat/context
branch
from
c98aa3a
to
807ffc1
Compare
|
Suggested version: Changes in diff --git a/go.mod b/go.mod
index 096a5f1..5ee071b 100644
--- a/go.mod
+++ b/go.mod
@@ -1,16 +1,16 @@
module github.com/ipfs/go-filestore
-go 1.12
+go 1.16
require (
- github.com/gogo/protobuf v1.3.1
- github.com/ipfs/go-block-format v0.0.2
- github.com/ipfs/go-cid v0.0.5
- github.com/ipfs/go-datastore v0.4.4
- github.com/ipfs/go-ipfs-blockstore v1.0.0
- github.com/ipfs/go-ipfs-ds-help v1.0.0
+ github.com/gogo/protobuf v1.3.2
+ github.com/ipfs/go-block-format v0.0.3
+ github.com/ipfs/go-cid v0.0.7
+ github.com/ipfs/go-datastore v0.5.0
+ github.com/ipfs/go-ipfs-blockstore v1.1.1
+ github.com/ipfs/go-ipfs-ds-help v1.1.0
github.com/ipfs/go-ipfs-posinfo v0.0.1
- github.com/ipfs/go-log v1.0.2
- github.com/ipfs/go-merkledag v0.3.1
- github.com/multiformats/go-multihash v0.0.13
+ github.com/ipfs/go-log v1.0.5
+ github.com/ipfs/go-merkledag v0.5.1
+ github.com/multiformats/go-multihash v0.0.15
)
|
|
This should be a v2, as the API was changed. |
|
@marten-seemann we're not bumping these to v2 as right now there is a good deal of complexity around the v0 and v1 (both in use) of this repo and they need to be swappable (i.e. I need to be able to drop in v1 as a v0 replacement). This choice is independent of, but related to, the decision to not release go-datastore as a v2 despite the breaking change with contexts. So we're knowingly doing the wrong thing. |
aschmahmann
approved these changes
Nov 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.