Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace uses of go-merkledag and go-ipld-format to create unixfs files with go-unixfsnode #293

Open
mvdan opened this issue Dec 2, 2021 · 2 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@mvdan
Copy link
Contributor

mvdan commented Dec 2, 2021

For example, in the code below, we use go-merkledag and go-ipld-format to create a UnixFS file for a benchmark:

dagService := merkledag.NewDAGService(blockservice.New(bs, offline.Exchange(bs)))
// import to UnixFS
bufferedDS := ipldformat.NewBufferedDAG(ctx, dagService)

@willscott says we can use data/builder.BuildUnixFSFile for this purpose:

https://github.com/ipfs/go-unixfsnode/blob/b9b6e9dc571e3fd0a3e4ee53987f07e0ff8008da/data/builder/file.go#L30

Hopefully this would mean that the root module no longer needs to pull those two dependencies, which are relatively large and getting phased out with time.

@mvdan mvdan added the need/triage Needs initial labeling and prioritization label Dec 2, 2021
@welcome

This comment has been minimized.

@hannahhoward
Copy link
Collaborator

ooh if go-unixfs node has gotten this far we should for SURE do this.

@mvdan mvdan removed their assignment Mar 23, 2022
marten-seemann pushed a commit that referenced this issue Mar 2, 2023
* refactor(cidsets): remove cidsets

* refactor(network): remove deprecated protocols

* refactor(cidlists): delete cidlists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants