Switch to google protobuf generator #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Address LeastAuthority/go-graphsync#2
Implementation
After tracking down the error, it appears the bug is in the generated Unmarshal code from gogoprotobuf. I tracked this down to the source code generator and found that the code actually patched the error in places but not in others. And, it appears gogo-protobuf is in a state of less than frequent maintainence, with an open request to assist with getting the code compatable with googles latest libraries. With this in mind, I decided to switch the library to google's own protobuf generator, which is still seeing frequent updates and presumably has more contributions and monitoring around security. I've gone ahead and regenerated based off of this. It requires a few code changes plus a switch to libp2p's msgio library.
But I've verified the previously panic'ing input no longer panic's. So that is good.