Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging to allocator #213

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Conversation

hannahhoward
Copy link
Collaborator

Goals

Add debug logs to track behavior of allocator to check for errors

For Discussion

This will make an already chatty graphsync debug log even more chatty but seems worth it

Add debug logs to track behavior of allocator to check for errors
Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, just wondering if it would be useful to separate the two "memory released" messages to make it clearer they are different funcs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants