Remove vector for memory leak #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubscribed block link
whyrusleeping
approved these changes
Oct 31, 2021
There was a problem hiding this comment.
This seems like it should solve the issue i was suspicious of (and generally seems like a good change for memory pressure in any case), but if it does fix what i was seeing, then that still means that these block operations are getting stuck in the subscriber thingy and we still need to figure that bit out
|
@whyrusleeping I agree, and unfortunately I believe the subscriber with the issue may be go-data-transfer :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
We pass one a "Block" interface for subscribers for BlockQueued and BlockSent hooks. The interface has no access to the data, but right now we hold a reference the raw block data in the implementing struct, and use it to calculate values. There's no need for this and ... eek... this could be a huge memory leak vector. It would also explain partly why we've had trouble replicating memory leaks in testplans -- it would be dependent on the behavior of the subscriber.
Anyway, can't hurt, and defensive programming