feat!(requestmanager): remove request allocation backpressure #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hannahhoward can you take a look please, two unticked items above from your original list - I'm not sure I see any backpressure use within the requestmanager itself, it seems to be in the graphsync receiver and the asyncloader only. Or is there a call somewhere that I should change? I also don't see obvious tests just for request backpressure, and nothing's failing when I remove all the plumbing. Is there anything that comes to mind that I've missed here? |
|
the good news is your PR is all good. The bad news is wow the situation with how we were using the allocator on the request side is even worse than I thought :( But at least it's bad news in the past new. |
hannahhoward
approved these changes
Nov 19, 2021
rvagg
added a commit
that referenced
this pull request
Nov 30, 2021
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #241
Ref: 9171ce6