mark all test helper funcs via t.Helper #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow testing errors to point to the caller position, which is more useful than where the test helper is declared. While here, use testing.TB for its intended purpose. That interface is broader than TestingT, but we're also never going to use an implementation other than testing.
This comment has been minimized.
This comment has been minimized.
masih
approved these changes
Nov 19, 2021
|
I didn't know about t.Helper! Thanks @mvdan |
rvagg
pushed a commit
that referenced
this pull request
Nov 30, 2021
This will allow testing errors to point to the caller position, which is more useful than where the test helper is declared. While here, use testing.TB for its intended purpose. That interface is broader than TestingT, but we're also never going to use an implementation other than testing.
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)