Don't run hooks on blocks we didn't have #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Jan 13, 2022
Comment on lines
193
to
194
| //ctx, cancel := context.WithTimeout(ctx, 5*time.Second) | ||
| //defer cancel() |
There was a problem hiding this comment.
did you intend to leave these commented out?
There was a problem hiding this comment.
just kidding! yes, oopsie.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Currently, when the remote peer has a missing block, when we attempt to load that block on the requestor side and discover the remote was missing it, we still run block hooks as if we received it. This is very confusing behavior.
Implementation
Don't run block hooks when loading a block errors on the requestor (the responder already avoids this)
Note: the vast majority of lines of new code in this PR are setting up a test.