chore: remove go-libp2p-core from go.mod #401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having (the deprecated) go-libp2p-core in
go.mod
causes problems when updating to go-libp2p v0.24.0 and higher (due to incompatible types). To be able to do so in lotus (and other consumers), it can't import any package that references go-libp2p-core.It was possible to remove the indirect dependency in
go.mod
withoutgo mod tidy
complaining. I had to re-add it as an indirect dependency in./testplans/graphsync
, but we don't care about that package when importing go-graphsync.