feat(graphsync): support extension protocol #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per ipld/specs#205, metadata is now an extension, and further extensions will be added soon
Stebalien
approved these changes
Nov 9, 2019
anorth
approved these changes
Nov 10, 2019
message/message.go
Outdated
| if !ok { | ||
| return nil, ErrExtensionNotPresent | ||
| } | ||
| return val, nil |
There was a problem hiding this comment.
Consider returning ([]byte, bool), leaving the interpretation of whether the missing value is an "error" up to the caller.
return a boolean instead of an error if an extention is found on a message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Bring implementation in line with spec, specifically ipld/specs#205
Implementation
Metadata is now an extension, and further extensions will be added soon