Send user extensions in request #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the ability to send extensions when creating requests
hannahhoward
changed the title
Stebalien
approved these changes
Nov 18, 2019
|
|
||
| returnedData2, found := gsr.Extension(extensionName2) | ||
| if !found || !reflect.DeepEqual(extensionData2, returnedData2) { | ||
| t.Fatal("Failed to encode first extension") |
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* refactor(graphsync): extract common utilities Simplify the graphsync implementation by extracting all utilities that aren't unique to graphsync to their own class. Also use stored counter from go-storedcounter (for persistence). Move extension utilities to seperate file * fix(deps): mod tidy, lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Allow Graphsync users to pass extensions data of their own in a Graphsync request.
Implementation