Add response hooks #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/response-hooks
branch
2 times, most recently
from
7c979e2
to
ebbe656
Compare
hannahhoward
force-pushed
the
feat/request-hooks
branch
from
4fc7302
to
492e1fd
Compare
define types and mock implementation for supporting extensions
Add processing of on extensions in responses in the request manager
DRY up integration test so it's more clear what each test is doing
hannahhoward
force-pushed
the
feat/response-hooks
branch
from
ebbe656
to
dffc8e6
Compare
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* feat(encoding): add library to handle encoding Create a new library for general type encoding * feat(registry): add simple registry add a simple threadsafe registry to handle registering types like vouchers * feat(datatransfer): incorporate registry incorporate registry into data transfer module * feat(message): move decoding inside messages Move encode/decode inside the message -- so that we can insure cbor encodable values, and then use cbg.Deferred later * feat(message): convert to cbg.Deferred convert messages to use cbg.Deferred so that the whole message is a proper CBOR value and also move selector encoding inside the message * refactor(graphsync): remove utils remove utils.go which is not used * refactor(registry): move types to root move Identifier & Registerable to root types package * refactor(datatransfer): minor refactors and cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Add ability to process incoming responses and halt requests as neccesary
Implementation