Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Added a ResolveFresh function to skip the cache #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apiarian
Copy link
Contributor

No description provided.

@whyrusleeping whyrusleeping added the status/in-progress In progress label Sep 14, 2016
@Kubuxu
Copy link
Member

Kubuxu commented Sep 28, 2016

@lgierth LGTY?

@Kubuxu Kubuxu added status/ready Ready to be worked status/deferred Conscious decision to pause or backlog and removed status/in-progress In progress status/ready Ready to be worked labels Sep 28, 2016
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI very badly needs fixing -- let me take care of that real quick.

Let me know about my comment, then definitely push your branch once more to trigger a new CI run

return s.resolve(id, false)
}

// ResolveFresh resolves the string provided to an /ipfs/[hash] without looking
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean /ipns/[hash] here? Same for the comment above Resolve()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it resolves the thing provided (which may be an ipns or an ipfs thing?) to an ipfs hash

This comment was marked as off-topic.

@ghost
Copy link

ghost commented Oct 5, 2016

Oh okay I fixed it to week ago already: #40 -- in that case, simply rebase your branch on master

@apiarian
Copy link
Contributor Author

apiarian commented Oct 5, 2016

@lgierth rebased

@apiarian
Copy link
Contributor Author

should i try rebasing again?

@whyrusleeping
Copy link
Member

This LGTM, cc @lgierth for 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/deferred Conscious decision to pause or backlog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants