This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
cache: switch to 2q #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to patent concerns in closed-source downstream products: ipfs/kubo#6590
|
@Stebalien worth renaming |
|
Meh. I didn't really want to break a bunch of stuff. I started with that but then realized we'd also have to rename the config options. ARC isn't trademarked, just patented. |
BrandonWeng
added a commit
to sei-protocol/sei-cosmos
that referenced
this pull request
Feb 3, 2023
## Describe your changes and provide context IRRC we had discussions around bumping the limit for the inter-block cache since 1k is pretty little for our volume of TXs per block. Im setting it to 100k to be the same as the BoundedCacheKv store While I was investigating the race condition issue in the LRU cache, I saw that several repos brought up concerns around using ArcCache in their code as it's been patented by IBM (and later sold to Intel) hashicorp/golang-lru#31 hashicorp/golang-lru#73 ipfs/kubo#6590 ipfs/go-ipfs-blockstore#20 Postgres and IPFS replaced it with 2Q, which based on the whitepaper should have the same performance as ARC. ## Testing performed to validate your change Deployed a LT cluster with these changes and saw no impact to consensus and the performance (with LT clients running) is similar 
codchen
pushed a commit
to sei-protocol/sei-cosmos
that referenced
this pull request
Feb 12, 2023
## Describe your changes and provide context IRRC we had discussions around bumping the limit for the inter-block cache since 1k is pretty little for our volume of TXs per block. Im setting it to 100k to be the same as the BoundedCacheKv store While I was investigating the race condition issue in the LRU cache, I saw that several repos brought up concerns around using ArcCache in their code as it's been patented by IBM (and later sold to Intel) hashicorp/golang-lru#31 hashicorp/golang-lru#73 ipfs/kubo#6590 ipfs/go-ipfs-blockstore#20 Postgres and IPFS replaced it with 2Q, which based on the whitepaper should have the same performance as ARC. ## Testing performed to validate your change Deployed a LT cluster with these changes and saw no impact to consensus and the performance (with LT clients running) is similar 
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
cache: switch to 2q This commit was moved from ipfs/go-ipfs-blockstore@4733550
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to patent concerns in closed-source downstream products:
ipfs/kubo#6590