Skip to content
This repository has been archived by the owner on Apr 24, 2021. It is now read-only.

Should add Int64Option/Uint64Option? #28

Closed
overbool opened this issue Aug 27, 2018 · 2 comments
Closed

Should add Int64Option/Uint64Option? #28

overbool opened this issue Aug 27, 2018 · 2 comments

Comments

@overbool
Copy link
Contributor

overbool commented Aug 27, 2018 •
edited
Loading

@lgierth should add Int64Option/Uint64Option?
see ipfs/kubo#5380
@overbool
Copy link
Contributor Author

overbool commented Sep 6, 2018

@lgierth Or should modify IntOption/UintOption to Int64Option/Uint64Option?

@Stebalien
Copy link
Member

Let's add a new type. However, let's also wait for ipfs/go-ipfs-cmds#112.

overbool added a commit to overbool/go-ipfs-cmdkit that referenced this issue Sep 20, 2018
@overbool
feat(type): fix issue ipfs#28
e48dff0
@overbool overbool mentioned this issue Sep 20, 2018
Merged
overbool added a commit to overbool/go-ipfs-cmdkit that referenced this issue Sep 20, 2018
@overbool
feat(type): fix issue ipfs#28
3687083
overbool added a commit to overbool/go-ipfs-cmdkit that referenced this issue Sep 20, 2018
@overbool
feat(type): fix issue ipfs#28
ff74515
Stebalien added a commit that referenced this issue Sep 28, 2018
@Stebalien
Merge pull request #29 from overbool/feat/issue-#28
386fcf8 
feat(type): fix issue #28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @overbool