check if we can decode an error before trying #108
Conversation
ghost
assigned 
|
Thanks for the fast response! |
cli/parse.go
Outdated
| @@ -15,7 +15,7 @@ import ( | |||
| "github.com/ipfs/go-ipfs-cmds" | |||
| logging "github.com/ipfs/go-log" | |||
|
|
|||
| osh "gx/ipfs/QmXuBJ7DR6k3rmUEKtvVMhwjmXDuJgXXPUt4LQXKBMsU93/go-os-helper" | |||
There was a problem hiding this comment.
I think importing the github path is okay, and the package is in the gx deps. I think I would remove the blank line above, though, or move logging below the blank line.
| @@ -210,6 +210,8 @@ func parseResponse(httpRes *http.Response, req *cmds.Request) (cmds.Response, er | |||
| } | |||
| e.Message = string(mes) | |||
| e.Code = cmdkit.ErrNormal | |||
| case res.dec == nil: | |||
There was a problem hiding this comment.
Hmm, we also use res.dec == nil to check whether the response is a io.Reader-style byte stream here:
Line 59 in 66802ba
There was a problem hiding this comment.
Can we have a raw bytes error?
There was a problem hiding this comment.
I'm not sure what you mean. Can you elaborate?
There was a problem hiding this comment.
This switch is trying to decode an error. Currently, it handles plain-text error responses, and "encoded" error responses (e.g., JSON). I don't think there are any valid cases where res.dec is nil and contentType isn't plain (for errors, at least).
cli/parse.go
Outdated
| @@ -15,7 +15,7 @@ import ( | |||
| "github.com/ipfs/go-ipfs-cmds" | |||
| logging "github.com/ipfs/go-log" | |||
|
|
|||
| osh "gx/ipfs/QmXuBJ7DR6k3rmUEKtvVMhwjmXDuJgXXPUt4LQXKBMsU93/go-os-helper" | |||
There was a problem hiding this comment.
I think importing the github path is okay, and the package is in the gx deps. I think I would remove the blank line above, though, or move logging below the blank line.
avoids a nil pointer dereference fixes ipfs/kubo#4998
avoids a nil pointer dereference
fixes ipfs/kubo#4998