Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip stdin test on Windows #136

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Conversation

djdv
Copy link
Contributor

@djdv djdv commented Dec 6, 2018

Issues around this were resolved, but the test was never "un-skipped".

C:\...\ipfs\go-ipfs-cmds\cli>systeminfo | findstr /B /C:"OS Version"
OS Version:                10.0.17763 N/A Build 17763

C:\...\ipfs\go-ipfs-cmds\cli>go test -v
=== RUN   TestSynopsisGenerator
--- PASS: TestSynopsisGenerator (0.00s)
    helptext_test.go:27: Synopsis is: cmd [--opt=<OPTION> | -o] [--] <required> [<variadic>...]
=== RUN   TestSameWords
--- PASS: TestSameWords (0.00s)
=== RUN   TestOptionParsing
--- PASS: TestOptionParsing (0.00s)
=== RUN   TestArgumentParsing
--- PASS: TestArgumentParsing (0.00s)
=== RUN   TestBodyArgs
--- PASS: TestBodyArgs (0.00s)
=== RUN   TestCloseWithError
--- PASS: TestCloseWithError (0.00s)
    responseemitter_test.go:88: 0
    responseemitter_test.go:47: stdout:
        ---
        a
        ---
    responseemitter_test.go:48: stderr:
        ---
        Error: some error
        ---
    responseemitter_test.go:88: 1
    responseemitter_test.go:47: stdout:
        ---
        a
        ---
    responseemitter_test.go:48: stderr:
        ---
        Error: some error
        ---
=== RUN   TestSingle
--- PASS: TestSingle (0.00s)
PASS
ok      github.com/ipfs/go-ipfs-cmds/cli        0.048s

License: MIT
Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
@djdv djdv requested a review from keks as a code owner December 6, 2018 15:43
@ghost ghost assigned djdv Dec 6, 2018
@ghost ghost added the status/in-progress In progress label Dec 6, 2018
@Stebalien Stebalien merged commit 9e804ce into ipfs:master Dec 6, 2018
@ghost ghost removed the status/in-progress In progress label Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants