Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gx publish 2.0.10 - Update cors library #139

Merged
merged 2 commits into from
Jan 11, 2019
Merged

gx publish 2.0.10 - Update cors library #139

merged 2 commits into from
Jan 11, 2019

Conversation

hsanjuan
Copy link
Contributor

@hsanjuan hsanjuan commented Jan 10, 2019

I have put an updated version of cors in the gxed organization. This updates it.

@hsanjuan hsanjuan requested a review from keks as a code owner January 10, 2019 20:06
@ghost ghost assigned hsanjuan Jan 10, 2019
@ghost ghost added the status/in-progress In progress label Jan 10, 2019
The cors library has changed behaviour.

Setting Access-Control-Allow-Origin to '*' will always return '*'.

See:

* Where change happened: rs/cors@8dd4211
* Current master: https://github.com/rs/cors/blob/a3460e445dd310dbefee993fe449f2ff9c08ae71/cors.go#L331
@hsanjuan
Copy link
Contributor Author

hsanjuan commented Jan 10, 2019

The cors library has changed behaviour and I had to fix tests.

Setting Access-Control-Allow-Origin to * will always return *.

See:

@hsanjuan hsanjuan changed the title gx publish 2.0.10 gx publish 2.0.10 - Update cors library Jan 10, 2019
@hsanjuan hsanjuan merged commit 49874fb into master Jan 11, 2019
@ghost ghost removed the status/in-progress In progress label Jan 11, 2019
@hsanjuan hsanjuan deleted the update/cors branch January 11, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants