Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: don't sync output to NUL on Windows #153

Merged
merged 1 commit into from
Mar 4, 2019
Merged

cli: don't sync output to NUL on Windows #153

merged 1 commit into from
Mar 4, 2019

Conversation

djdv
Copy link
Contributor

@djdv djdv commented Mar 4, 2019

I know the documentation seems backwards, but it's not.
fixes ipfs/kubo#6039
followup to #146

@djdv djdv requested a review from keks as a code owner March 4, 2019 19:15
@ghost ghost assigned djdv Mar 4, 2019
@ghost ghost added the status/in-progress In progress label Mar 4, 2019
@Stebalien Stebalien merged commit b21055c into ipfs:master Mar 4, 2019
@Stebalien
Copy link
Member

Thanks!

@ghost ghost removed the status/in-progress In progress label Mar 4, 2019
@djdv djdv mentioned this pull request Mar 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@keks keks Awaiting requested review from keks

Assignees

@djdv djdv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird error piping to >NUL
2 participants
@djdv @Stebalien