Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve error codes #168

Merged
merged 1 commit into from
Jun 11, 2019
Merged

feat: improve error codes #168

merged 1 commit into from
Jun 11, 2019

Conversation

Stebalien
Copy link
Member

  • remove ErrNotFound - it isn't used. If we want to type not-found errors, we should consider adding a new error "subtype" field. All the current errors are effectively transport-level errors.
  • remove ErrFatal - it's unclear how this should be handled.
  • add ErrRateLimited - requested by @MichaelMure
  • add ErrForbidden

@Stebalien
feat: improve error codes
d9d26d6 
* remove ErrNotFound - it isn't used. If we want to type not-found errors, we
  should consider adding a new error "subtype" field. All the current errors are
  effectively transport-level errors.
* remove ErrFatal - it's unclear how this should be handled.
* add ErrRateLimited - requested by @MichaelMure
* add ErrForbidden
@Stebalien Stebalien mentioned this pull request Jun 5, 2019
Closed
@Stebalien Stebalien merged commit 6069424 into master Jun 11, 2019
@Stebalien Stebalien deleted the feat/error-codes branch June 11, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @magik6k