Special-case accepting explicitly supplied named pipes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested changes
Mar 16, 2020
cli/parse.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return files.NewReaderPathFile(fpath, file, stat) |
There was a problem hiding this comment.
The path & stat should be nil.
- The path should only refer to files that can actually be read. The filestore/urlstore features will use it.
- The stat will be used to determine the size of the file. It'll give us very incorrect information in this case.
There was a problem hiding this comment.
path is a string, so I went with "" ( thought of using newMessageReader but proably incorrect in this case ). There were zero changes needed in the go-ipfs test suite ( aside from ipfs/kubo#6998 obviously ), so this seems like the right thing to do.
Stebalien
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is properly tested in go-ipfs ( can't open PR before bubbling this as a release )