change HandledMethods to AllowGet and cleanup method handling #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing methods isn't as simple as just allowing/disallowing them because different methods do different things. * HEAD: should be allowed everywhere GET is allowed. * OPTIONS: * When a CORS request is made, this will be handled by the CORS library. * Otherewise, we need to return the allowed methods. * POST: always allowed. * Everything else: always denied. Changing HandledMethods to a simple AllowGet makes it easier to "do the right thing".
hsanjuan
approved these changes
Apr 4, 2020
|
I'll bubble to go-ipfs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing methods isn't as simple as just allowing/disallowing them because different methods do different things.
Changing HandledMethods to a simple AllowGet makes it easier to "do the right thing".