-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build on Plan 9 #199
Fix build on Plan 9 #199
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
the posix/windows implementations include EINVAL and ENOTSUP style errors in the check. |
This function seems to be only called with an unwrapped |
It seems like it shouldn't hurt, and hopefully reduces the potential for surprise in the future if it stays consistent with other platforms it case it gets used for something else |
I've added |
No description provided.