Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Plan 9 #199

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Fix build on Plan 9 #199

merged 1 commit into from
Aug 1, 2020

Conversation

fhs
Copy link
Contributor

@fhs fhs commented Aug 1, 2020

No description provided.

@welcome
Copy link

welcome bot commented Aug 1, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@willscott
Copy link
Contributor

the posix/windows implementations include EINVAL and ENOTSUP style errors in the check.
plan9 also at least defines these (syscall.EINVAL and syscall.EPLAN9). Is there a reason those shouldn't bubble up to returning true in isErrnoNotSupported?

@fhs
Copy link
Contributor Author

fhs commented Aug 1, 2020

the posix/windows implementations include EINVAL and ENOTSUP style errors in the check.
plan9 also at least defines these (syscall.EINVAL and syscall.EPLAN9). Is there a reason those shouldn't bubble up to returning true in isErrnoNotSupported?

This function seems to be only called with an unwrapped os.PathError error returned by File.Sync. File.Sync can return os.ErrInvalid for nil receiver, but it's not wrapped in os.PathError. I don't think it ever returns syscall.EINVAL or syscall.EPLAN9. I can return true for those errors if the function is meant for general use, not just to check File.Sync errors.

@willscott
Copy link
Contributor

I can return true for those errors if the function is meant for general use, not just to check File.Sync errors.

It seems like it shouldn't hurt, and hopefully reduces the potential for surprise in the future if it stays consistent with other platforms it case it gets used for something else

@fhs
Copy link
Contributor Author

fhs commented Aug 1, 2020

I've added syscall.EINVAL and syscall.EPLAN9. os.ErrInvalid is not being checked on unix or windows, so leaving that out.

@willscott willscott mentioned this pull request Aug 1, 2020
@willscott willscott merged commit 0cd468a into ipfs:master Aug 1, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants