Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve staticcheck issue in prep for unified CI #212

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

masih
Copy link
Member

@masih masih commented Jul 21, 2021

Resolve staticcheck issue S1040 caused by unnecessary type assertion.

Run go mod tidy

Relates to:

@welcome
Copy link

welcome bot commented Jul 21, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@masih masih marked this pull request as ready for review July 21, 2021 10:39
Resolve `staticcheck` issue S1040 caused by unnecessary type assertion.

Run `go mod tidy`

Relates to:
- https://github.com/orgs/ipfs/projects/12#card-58209321
@masih masih force-pushed the masih/fix-staticcheck-issue branch from 73d3a12 to f1085fd Compare July 21, 2021 10:40
@marten-seemann marten-seemann merged commit 744f3b3 into master Jul 21, 2021
@masih masih deleted the masih/fix-staticcheck-issue branch July 21, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants