This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
petar/remotepin
branch
from
December 4, 2020 21:17
f5c0084
to
26a8d86
Compare
aschmahmann
force-pushed
the
feat/pinmfs
branch
from
December 4, 2020 21:18
2c0d54c
to
2051dc1
Compare
petar
approved these changes
Dec 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aschmahmann
force-pushed
the
petar/remotepin
branch
from
December 5, 2020 22:16
26a8d86
to
ad6e7f2
Compare
aschmahmann
force-pushed
the
feat/pinmfs
branch
from
December 5, 2020 22:20
2051dc1
to
71378d7
Compare
aschmahmann
force-pushed
the
petar/remotepin
branch
from
December 5, 2020 22:22
ad6e7f2
to
84cb43b
Compare
aschmahmann
force-pushed
the
feat/pinmfs
branch
from
December 5, 2020 22:24
71378d7
to
7f4bfc6
Compare
aschmahmann
commented
Dec 5, 2020
aschmahmann
commented
Dec 5, 2020
aschmahmann
force-pushed
the
feat/pinmfs
branch
from
December 9, 2020 14:32
7f4bfc6
to
3fdd66a
Compare
lidel
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Note that even tho we use json:",omitempty"
for Policies
and MFS
structs, theRemotePinningServiceMFSPolicy.Enable
is bool
, so ipfs pin remote service add
will create an explicit Policies.MFS
:
"RemoteServices": {
"testsrv": {
"API": {
"Endpoint": "https://testsrv.example.com",
"Key": "secret"
},
"Policies": {
"MFS": {
"Enable": false
}
}
}
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for ipfs/kubo#7798
Part of ipfs/kubo#7559 / ipfs/ipfs-gui#91