Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Add Init Alternative allowing specification of ED25519 key #78

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Add Init Alternative allowing specification of ED25519 key #78

merged 3 commits into from
Apr 28, 2020

Conversation

willscott
Copy link
Contributor

to support generating other types of keys at initialization as tracked by ipfs/kubo#6916

@willscott willscott requested a review from Stebalien April 21, 2020 00:41
Stebalien
Stebalien reviewed Apr 21, 2020
View reviewed changes
init.go Outdated Show resolved Hide resolved
jacobheun
jacobheun reviewed Apr 28, 2020
View reviewed changes
Copy link

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage in this repo is pretty bad, perhaps we should add some tests here to validate we're getting the correct keys?

Updated approach LGTM

@willscott
Copy link
Contributor Author

added a test 👍

@willscott willscott merged commit dafde61 into master Apr 28, 2020
@Stebalien Stebalien mentioned this pull request May 26, 2020
Closed
77 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobheun jacobheun jacobheun left review comments

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willscott @Stebalien @jacobheun