chore(filewriter): cleanup writes #43
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
|
Is there a reason this isn't merged? |
|
@aschmahmann @schomatis : can we merge? |
filewriter.go
Outdated
| switch nd := nd.(type) { | ||
| case *Symlink: | ||
| return os.Symlink(nd.Target, fpath) | ||
| case File: | ||
| f, err := os.Create(fpath) | ||
| f, err := os.OpenFile(fpath, os.O_EXCL|os.O_CREATE|os.O_WRONLY, 0666) |
There was a problem hiding this comment.
@schomatis could you add back the O_NOFOLLOW flag for when we're running on systems that support it? We already have some OS specific files here so it should be pretty easy to add in another function to get OS specific symlink flags. Once that's done we can merge here.
schomatis
force-pushed
the
schomatis/chore/cleanup-writes
branch
from
3b200d5
to
004fb74
Compare
No description provided.