Skip to content
This repository has been archived by the owner on Oct 5, 2023. It is now read-only.

feat: improved interop with go-ipfs 0.13 #160

Merged
merged 1 commit into from
Jun 23, 2022
Merged

feat: improved interop with go-ipfs 0.13 #160

merged 1 commit into from
Jun 23, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 3, 2022

This PR ensures ipfs block put --cid-codec introduced in ipfs/kubo#8568 gets correctly passed (+ we maintain backward-compatibility with --format=v0 when CIDv0 is present).

It also helps with go.mod issue described in #159

TODO

  • remove go 1.16 support to match go-ipfs
  • remove use of cid.CodecToStr
  • make go test pass
  • make CI pass
    • NOTE: had to stay on older versions of some deps so iptb-plugins used in tests work
  • bump version to v0.4.0

Closes #159

This ensures cid-codec introduced in ipfs/kubo#8568
gets correctly passed (+ we maintain backward-compatibility with CIDv0)
@lidel lidel force-pushed the feat/go-ipfs-0.13 branch from 93a5b2a to 5d280d8 Compare June 3, 2022 15:59
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Suggested version: v0.4.0
Comparing to: v0.3.1 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index 00600ec..ee6485d 100644
--- a/go.mod
+++ b/go.mod
@@ -2,23 +2,76 @@ module github.com/ipfs/go-ipfs-http-client
 
 require (
 	github.com/ipfs/go-block-format v0.0.3
-	github.com/ipfs/go-cid v0.0.7
-	github.com/ipfs/go-ipfs-cmds v0.6.0
-	github.com/ipfs/go-ipfs-files v0.0.8
+	github.com/ipfs/go-cid v0.1.0
+	github.com/ipfs/go-ipfs-cmds v0.7.0
+	github.com/ipfs/go-ipfs-files v0.1.1
 	github.com/ipfs/go-ipld-format v0.4.0
 	github.com/ipfs/go-merkledag v0.6.0
-	github.com/ipfs/go-path v0.1.1
-	github.com/ipfs/go-unixfs v0.2.5
+	github.com/ipfs/go-path v0.3.0
+	github.com/ipfs/go-unixfs v0.3.1
 	github.com/ipfs/interface-go-ipfs-core v0.7.0
 	github.com/ipfs/iptb v1.4.0
 	github.com/ipfs/iptb-plugins v0.3.0
 	github.com/libp2p/go-libp2p-core v0.8.6
 	github.com/mitchellh/go-homedir v1.1.0
-	github.com/multiformats/go-multiaddr v0.3.3
+	github.com/multiformats/go-multiaddr v0.5.0
 	github.com/multiformats/go-multibase v0.0.3
 	github.com/multiformats/go-multicodec v0.4.1
-	github.com/multiformats/go-multihash v0.0.15
+	github.com/multiformats/go-multihash v0.1.0
 	github.com/pkg/errors v0.9.1
 )
 
-go 1.16
+require (
+	github.com/btcsuite/btcd v0.21.0-beta // indirect
+	github.com/crackcomm/go-gitignore v0.0.0-20170627025303-887ab5e44cc3 // indirect
+	github.com/facebookgo/atomicfile v0.0.0-20151019160806-2de1f203e7d5 // indirect
+	github.com/gogo/protobuf v1.3.2 // indirect
+	github.com/google/uuid v1.2.0 // indirect
+	github.com/hashicorp/golang-lru v0.5.4 // indirect
+	github.com/ipfs/bbloom v0.0.4 // indirect
+	github.com/ipfs/go-blockservice v0.3.0 // indirect
+	github.com/ipfs/go-datastore v0.5.0 // indirect
+	github.com/ipfs/go-ipfs-blockstore v1.2.0 // indirect
+	github.com/ipfs/go-ipfs-chunker v0.0.1 // indirect
+	github.com/ipfs/go-ipfs-config v0.5.3 // indirect
+	github.com/ipfs/go-ipfs-ds-help v1.1.0 // indirect
+	github.com/ipfs/go-ipfs-exchange-interface v0.1.0 // indirect
+	github.com/ipfs/go-ipfs-posinfo v0.0.1 // indirect
+	github.com/ipfs/go-ipfs-util v0.0.2 // indirect
+	github.com/ipfs/go-ipld-cbor v0.0.5 // indirect
+	github.com/ipfs/go-ipld-legacy v0.1.0 // indirect
+	github.com/ipfs/go-log v1.0.5 // indirect
+	github.com/ipfs/go-log/v2 v2.3.0 // indirect
+	github.com/ipfs/go-metrics-interface v0.0.1 // indirect
+	github.com/ipfs/go-verifcid v0.0.1 // indirect
+	github.com/ipld/go-codec-dagpb v1.3.0 // indirect
+	github.com/ipld/go-ipld-prime v0.11.0 // indirect
+	github.com/jbenet/goprocess v0.1.4 // indirect
+	github.com/klauspost/cpuid/v2 v2.0.9 // indirect
+	github.com/libp2p/go-buffer-pool v0.0.2 // indirect
+	github.com/libp2p/go-openssl v0.0.7 // indirect
+	github.com/mattn/go-isatty v0.0.13 // indirect
+	github.com/minio/blake2b-simd v0.0.0-20160723061019-3f5f724cb5b1 // indirect
+	github.com/minio/sha256-simd v1.0.0 // indirect
+	github.com/mr-tron/base58 v1.2.0 // indirect
+	github.com/multiformats/go-base32 v0.0.3 // indirect
+	github.com/multiformats/go-base36 v0.1.0 // indirect
+	github.com/multiformats/go-varint v0.0.6 // indirect
+	github.com/opentracing/opentracing-go v1.2.0 // indirect
+	github.com/polydawn/refmt v0.0.0-20201211092308-30ac6d18308e // indirect
+	github.com/rs/cors v1.7.0 // indirect
+	github.com/spacemonkeygo/spacelog v0.0.0-20180420211403-2296661a0572 // indirect
+	github.com/spaolacci/murmur3 v1.1.0 // indirect
+	github.com/whyrusleeping/cbor-gen v0.0.0-20200123233031-1cdf64d27158 // indirect
+	github.com/whyrusleeping/chunker v0.0.0-20181014151217-fe64bd25879f // indirect
+	go.uber.org/atomic v1.7.0 // indirect
+	go.uber.org/multierr v1.7.0 // indirect
+	go.uber.org/zap v1.16.0 // indirect
+	golang.org/x/crypto v0.0.0-20210513164829-c07d793c2f9a // indirect
+	golang.org/x/sys v0.0.0-20210514084401-e8d321eab015 // indirect
+	golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
+	google.golang.org/protobuf v1.27.1 // indirect
+	lukechampine.com/blake3 v1.1.6 // indirect
+)
+
+go 1.17

gorelease says:

# summary
Suggested version: v0.4.0

gocompat says:

(empty)

@lidel
Copy link
Member Author

lidel commented Jun 23, 2022

go-ipfs 0.13 shipped, and this is blocking at least two teams I am aware of, merging in effort to unstuck people

@lidel lidel merged commit 9c9f43f into master Jun 23, 2022
@lidel lidel deleted the feat/go-ipfs-0.13 branch June 23, 2022 20:39
@BigLep BigLep mentioned this pull request Jul 26, 2022
68 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incompatibility with go-cid@v0.2.0: go-ipfs-http-client@v0.3.1/dag.go:59:16: undefined: cid.CodecToStr
1 participant