Fix commands --flags not showing flags via HTTP API #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was caused by the cmds.Option struct being Interface not struct The solution is to create struct and copy interesting data over. Also removed the "ShowOptions" field from being sent via the HTTP API. License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
|
@RichardLitt this introduces small change into the API. |
|
Wow, I didn't even know this option existed. Cool! |
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
force-pushed
the
feature/commands-flags
branch
from
69e3c87
to
7167e93
Compare
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was caused by the cmds.Option struct being Interface not struct
The solution is to create struct and copy interesting data over.
Also removed the "ShowOptions" field from being sent via the HTTP API.
This introduces small change to the API.
I will yet add tests for this bug.
Resolves #2301
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch