Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate sharness tests for reported bugs and regressions #2774

Closed
Kubuxu opened this issue May 31, 2016 · 5 comments
Closed

Separate sharness tests for reported bugs and regressions #2774

Kubuxu opened this issue May 31, 2016 · 5 comments
Labels
kind/test Testing work need/community-input Needs input from the wider community

Comments

@Kubuxu
Copy link
Member

Kubuxu commented May 31, 2016 •
edited
Loading

Some of tests fit currently named types but some of the would be too specific or too weird to fit in already named kind. What do you thing about creating two more kinds of tests:

  • t0500-issues-and-regressions-offline.sh
  • t0501-issues-and-regressions-online.sh

Where tests would be created by per issues/bug basis and would specify for which issues exactly where they created.
@whyrusleeping
Copy link
Member

I like this idea, we should do this.

@Kubuxu
Copy link
Member Author

Kubuxu commented May 31, 2016

I am adding them with #2773

@chriscool
Copy link
Contributor

Yeah, but if overtime we create many tests for bugs, the t0500 and t0501test scripts could become very big and messy.

We should at least reserve some test numbers for more test scripts of both kind. For example t05XX for offline issues and regressions, and t06XX for online issues and regressions.

@Kubuxu
Copy link
Member Author

Kubuxu commented Jun 1, 2016

Seems like a smart idea. Let's move them over before there is much of a mess.

@Kubuxu Kubuxu self-assigned this Jun 1, 2016
@whyrusleeping whyrusleeping added kind/test Testing work need/community-input Needs input from the wider community labels Jun 1, 2016
Kubuxu added a commit that referenced this issue Jun 2, 2016
@Kubuxu
Move tests around as for #2774
3c1f3da 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu added a commit that referenced this issue Jun 2, 2016
@Kubuxu
Move tests around as for #2774
8970289 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu added a commit that referenced this issue Jun 2, 2016
@Kubuxu
Move tests around as for #2774
c8c329d 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu Kubuxu closed this as completed Jun 2, 2016
@Kubuxu
Copy link
Member Author

Kubuxu commented Jun 2, 2016

Done in #2773, moved them around in #2790

@Kubuxu Kubuxu removed their assignment Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/test Testing work need/community-input Needs input from the wider community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chriscool @whyrusleeping @Kubuxu