Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build for all supported platforms when testing #4445

Merged
merged 1 commit into from
Dec 4, 2017
Merged

build for all supported platforms when testing #4445

merged 1 commit into from
Dec 4, 2017

Conversation

Stebalien
Copy link
Member

fixes #4427

(I'm not a make expert, please review)

@Stebalien
build for all supported platforms when testing
6917d2f 
fixes #4427

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Dec 1, 2017
@ghost ghost added the status/in-progress In progress label Dec 1, 2017
@Stebalien Stebalien requested a review from Kubuxu December 1, 2017 06:05
@Stebalien Stebalien mentioned this pull request Dec 1, 2017
Closed
Kubuxu
Kubuxu approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, only issue I can see is that CGO will be disabled for those builds but enabling it would require a lot of compilers (all arch+system combinations) on machine for whoever is running the checks.

@whyrusleeping whyrusleeping merged commit e8cad12 into master Dec 4, 2017
@whyrusleeping whyrusleeping deleted the fix/4427 branch December 4, 2017 19:12
@ghost ghost removed the status/in-progress In progress label Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use GOOS to build on all platforms
3 participants
@Stebalien @Kubuxu @whyrusleeping