Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORS] Bubble go-ipfs-cmds 2.0.10 - Updates CORS library #5919

Merged
merged 2 commits into from
Jan 11, 2019

Conversation

hsanjuan
Copy link
Contributor

Merge only after ipfs/go-ipfs-cmds#139

Small behaviour change but should not affect things.

License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
@hsanjuan hsanjuan added the status/blocked Unable to be worked further until needs are met label Jan 10, 2019
@hsanjuan hsanjuan requested a review from Kubuxu as a code owner January 10, 2019 20:32
@ghost ghost assigned hsanjuan Jan 10, 2019
@ghost ghost added the status/in-progress In progress label Jan 10, 2019
@hsanjuan
Copy link
Contributor Author

Fixes one item in #5745

@hsanjuan hsanjuan changed the title Bubble go-ipfs-cmds 2.0.10 Bubble go-ipfs-cmds 2.0.10 - Updates cors library Jan 10, 2019
@hsanjuan hsanjuan changed the title Bubble go-ipfs-cmds 2.0.10 - Updates cors library [CORS] Bubble go-ipfs-cmds 2.0.10 - Updates CORS library Jan 10, 2019
@Stebalien
Copy link
Member

Looks like some error checks in the API sharness tests need to be updated for ipfs/go-ipfs-cmds#138.

@hsanjuan
Copy link
Contributor Author

Ỳeah I noticed. Will go through that later.

@hsanjuan hsanjuan removed the status/blocked Unable to be worked further until needs are met label Jan 11, 2019
License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
@hsanjuan
Copy link
Contributor Author

@Stebalien I have fixed the sharness. I don't think the rest of failing tests are my fault.

@Stebalien Stebalien merged commit b36037a into master Jan 11, 2019
@ghost ghost removed the status/in-progress In progress label Jan 11, 2019
@Stebalien Stebalien deleted the gx/cmds-and-cors branch January 11, 2019 23:40
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
[CORS] Bubble go-ipfs-cmds 2.0.10 - Updates CORS library

This commit was moved from ipfs/kubo@b36037a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants