Introducing EncodedFSKeystore with base32 encoding (#5947) #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2020
|
Ready on my side, I made minor changes over what was already approved. I tagged a test version and built a custom dist release so that it can be tested with https://github.com/ipfs/fs-repo-migrations/pull/96/files |
Stebalien
reviewed
Mar 14, 2020
Stebalien
force-pushed
the
feat/AuHau-encoding-key-names
branch
from
5f38c18
to
060cdab
Compare
hsanjuan
commented
Mar 15, 2020
Stebalien
reviewed
Mar 15, 2020
Stebalien
approved these changes
Mar 16, 2020
hsanjuan
force-pushed
the
feat/AuHau-encoding-key-names
branch
from
13f0c20
to
cbb4017
Compare
|
@Stebalien I have squashed the commit history. However we need to merge ipfs/fs-repo-migrations#96 and release fs-repo-migrations before proceeding here. |
|
I've cut a release: ipfs/distributions#285. |
|
(well, I haven't published it yet but I figured we should test it first) |
This was referenced Mar 23, 2020
Encoding the key's filename with base32 introduces coherent behaviour across different platforms and their case-sensitive/case-insensitive file-systems. Moreover it allows wider character set to be used for the name of the keys as the original restriction for special FS's characters (e.g. '/', '.') will not apply. License: MIT Signed-off-by: Adam Uhlir <uhlir.a@gmail.com>
* Use Go's base32 library * Set repo to version 9 * Resolve linting problems and docs. * Merge EncodedFSKeystore into FSKeystore * Remove name limitations and adjust tests
Stebalien
force-pushed
the
feat/AuHau-encoding-key-names
branch
from
cbb4017
to
2a27519
Compare
Stebalien
force-pushed
the
feat/AuHau-encoding-key-names
branch
from
2a27519
to
0d9d6e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from #6012
Encoding the key's filename with base32 introduces coherent behaviour
across different platforms and their case-sensitive/case-insensitive
file-systems. Moreover it allows wider character set to be used for the
name of the keys as the original restriction for special FS's characters
(e.g. '/', '.') will not apply.
License: MIT
Signed-off-by: Adam Uhlir uhlir.a@gmail.com