More p2p proxy checks #7797
Merged
More p2p proxy checks #7797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
fix/p2p-proxy-checks
branch
from
68e19dc
to
a6f3cdc
Compare
aschmahmann
force-pushed
the
fix/p2p-proxy-checks
branch
from
a6f3cdc
to
76f3395
Compare
aschmahmann
commented
Dec 4, 2020
Comment on lines
+64
to
+66
| if _, err := peer.Decode(split[2]); err != nil { | ||
| return nil, fmt.Errorf("Invalid request path '%s'", path) | ||
| } |
There was a problem hiding this comment.
This effectively changes the error code for an invalid peerID from 502 to 400 and shows an error to the user instead of just logging on the server.
Stebalien
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few checks to the p2p proxy to return errors to the client rather than just logging them on the daemon.