p2p-proxy: earlier peerID validation check

ipfs · Dec 1, 2020 · 68e19dc · 68e19dc
1 parent a329e4f
commit 68e19dc
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/core/corehttp/p2p_proxy.go b/core/corehttp/p2p_proxy.go
@@ -9,6 +9,7 @@ import (
 	"strings"
 
 	core "github.com/ipfs/go-ipfs/core"
+	peer "github.com/libp2p/go-libp2p-core/peer"
 
 	protocol "github.com/libp2p/go-libp2p-core/protocol"
 	p2phttp "github.com/libp2p/go-libp2p-http"
@@ -60,6 +61,10 @@ func parseRequest(request *http.Request) (*proxyRequest, error) {
 		return nil, fmt.Errorf("Invalid request path '%s'", path)
 	}
 
+	if _, err := peer.Decode(split[2]); err != nil {
+		return nil, fmt.Errorf("Invalid request path '%s'", path)
+	}
+
 	if split[3] == "http" {
 		return &proxyRequest{split[2], protocol.ID("/http"), split[4]}, nil
 	}