Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go-libp2p to v0.20.3 #9038

Merged
merged 3 commits into from
Jun 30, 2022
Merged

update go-libp2p to v0.20.3 #9038

merged 3 commits into from
Jun 30, 2022

Conversation

marten-seemann
Copy link
Member

Removing a whole bunch of deps:

 go.mod | 29 +++++++++--------------------
 1 file changed, 9 insertions(+), 20 deletions(-)

Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR causes https://github.com/ipfs/go-ipfs/blob/master/test/sharness/t0125-twonode.sh to reliably hang (i.e. master works fine and this does not). We can't merge until that's resolved.

Test failure seems to be QUIC specific. See the end of the logs in https://app.circleci.com/pipelines/github/ipfs/go-ipfs/7042/workflows/0305f2cd-270d-409a-868e-6911f1f872a2/jobs/76496 or just run the test on your own to see.

A little bit of poking around seems to indicate it might be related to the opening of QUIC streams, which is probably a good place to start looking. The "poking around" was using https://github.com/aschmahmann/vole and hitting a local node with only QUIC enabled and noticing that the stream handler wasn't getting called. Haven't poked around any further than that.

@MarcoPolo
Copy link
Contributor

Could you share the steps you used with vole to repro? I'm not familiar with it sorry.

@aschmahmann
Copy link
Contributor

Should be fairly straightforward:

  1. Build this branch of go-ipfs (go build ./cmd/ipfs)
  2. Set all transports other than QUIC to false https://github.com/ipfs/go-ipfs/blob/master/docs/config.md
  3. Build vole and do something like vole.exe bitswap check <someCID> /ip6/::1/udp/4001/quic/p2p/<yourPeerID> and see if it responds. It if it doesn't respond with a result then something bad is going on.

@marten-seemann marten-seemann changed the title update go-libp2p to v0.20.1 update go-libp2p to v0.20.2 Jun 24, 2022
@marten-seemann
Copy link
Member Author

Updated to go-libp2p v0.20.2.

@aschmahmann
Copy link
Contributor

@marten-seemann it looks like the issue is still present in the same test as above, i.e. doesn't look like the go-multistream change was sufficient.

The vole test above fails the same way too.

@marten-seemann marten-seemann changed the title update go-libp2p to v0.20.2 update go-libp2p to v0.20.3 Jun 29, 2022
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarcoPolo and @marten-seemann 🙏.

@aschmahmann aschmahmann merged commit 123f1f6 into master Jun 30, 2022
@aschmahmann aschmahmann deleted the update-libp2p-v020 branch June 30, 2022 19:21
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
update go-libp2p to v0.20.3

This commit was moved from ipfs/kubo@123f1f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants