-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update go-libp2p to v0.20.3 #9038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR causes https://github.com/ipfs/go-ipfs/blob/master/test/sharness/t0125-twonode.sh to reliably hang (i.e. master works fine and this does not). We can't merge until that's resolved.
Test failure seems to be QUIC specific. See the end of the logs in https://app.circleci.com/pipelines/github/ipfs/go-ipfs/7042/workflows/0305f2cd-270d-409a-868e-6911f1f872a2/jobs/76496 or just run the test on your own to see.
A little bit of poking around seems to indicate it might be related to the opening of QUIC streams, which is probably a good place to start looking. The "poking around" was using https://github.com/aschmahmann/vole and hitting a local node with only QUIC enabled and noticing that the stream handler wasn't getting called. Haven't poked around any further than that.
Could you share the steps you used with vole to repro? I'm not familiar with it sorry. |
Should be fairly straightforward:
|
76c566b
to
ec61dd4
Compare
Updated to go-libp2p v0.20.2. |
@marten-seemann it looks like the issue is still present in the same test as above, i.e. doesn't look like the go-multistream change was sufficient. The vole test above fails the same way too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarcoPolo and @marten-seemann 🙏.
update go-libp2p to v0.20.3 This commit was moved from ipfs/kubo@123f1f6
Removing a whole bunch of deps: