Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to allocate a bit less #45

Merged
merged 1 commit into from
Sep 25, 2018
Merged

attempt to allocate a bit less #45

merged 1 commit into from
Sep 25, 2018

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Sep 25, 2018

  1. Traverse once.
  2. Avoid fmt.

@dignifiedquire this may not help but could you test if you have time? The internal benchmarks don't seem to capture real-world gc issues very well.

1. Traverse once.
2. Avoid fmt.
@ghost ghost assigned Stebalien Sep 25, 2018
@ghost ghost added the status/in-progress In progress label Sep 25, 2018
@dignifiedquire
Copy link
Member

will try out in my code later today and report back

@dignifiedquire
Copy link
Member

It seems about 5% faster in my tests (note I patched this in, on an older version, as I haven't updated to master from here yet)

@Stebalien
Copy link
Member Author

Well... that's still a win.

@Stebalien Stebalien merged commit 969ab0f into master Sep 25, 2018
@ghost ghost removed the status/in-progress In progress label Sep 25, 2018
@dignifiedquire
Copy link
Member

After fixing some things in my code this makes my tests go from 61s do 45s! so really nice improvements

@whyrusleeping whyrusleeping deleted the feat/allocate-less branch September 27, 2018 17:21
dignifiedquire added a commit to filecoin-project/venus that referenced this pull request Sep 27, 2018
* perf: improve actor storage performance

This minimizes the amount of marshal & unmarshal calls being made when using `actor.WithStorage`.

I used the test `TestTipSetWeightDeep` as benchmark and went from `140s` to `61s`.

When applying ipfs/go-ipld-cbor#45 the time goes down to `45s`.

Warning: this reduces the strictness of the vm memory barrier with the rest of filecoin, but we accept this as a tradeof for now, to improve performance. 

Ref #979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants