Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't panic on invalid log labels #110

Merged
merged 2 commits into from
Apr 17, 2021
Merged

fix: don't panic on invalid log labels #110

merged 2 commits into from
Apr 17, 2021

Conversation

Stebalien
Copy link
Member

No description provided.

schomatis
schomatis approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this a panic?

setup.go Outdated Show resolved Hide resolved
@Stebalien @schomatis
fix: improve invalid label error message
967f31a 
Co-authored-by: Lucas Molas <schomatis@gmail.com>
@Stebalien
Copy link
Member Author

Why was this a panic?

Without an =, the slice length would be 1 and kv[1] would have paniced.

@Stebalien Stebalien merged commit 8621457 into master Apr 17, 2021
@Stebalien Stebalien deleted the fix/log-label-panic branch April 17, 2021 02:04
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schomatis schomatis schomatis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @schomatis