Deprecate EventLogging and Warning* functions #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Stebalien
reviewed
Jul 3, 2019
log.go
Outdated
| @@ -41,6 +43,9 @@ type StandardLogger interface { | |||
| type EventLogger interface { | |||
| StandardLogger | |||
|
|
|||
| Warn(args ...interface{}) | |||
There was a problem hiding this comment.
I can't require them on StandardLogger as why/log doesn't implement them.
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
|
I figured out how to make the interface nicer. |
|
With Zap we can switch Event logs to structured logs. |
Stebalien
approved these changes
Jul 3, 2019
|
I can't reproduce it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first set toward migrating this pacakage away from event logging and
toward Zap.
The aim is for this pacakge to be a manager for Zap loggers.