-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove go-ipld-format globals #105
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
f20b322
to
eceea55
Compare
@@ -11,7 +11,6 @@ require ( | |||
github.com/ipfs/go-ipfs-blockstore v1.2.0 | |||
github.com/ipfs/go-ipfs-exchange-offline v0.3.0 | |||
github.com/ipfs/go-ipfs-util v0.0.2 | |||
github.com/ipfs/go-ipld-cbor v0.0.6 | |||
github.com/ipfs/go-ipld-format v0.4.0 | |||
github.com/ipfs/go-ipld-legacy v0.1.2-0.20230530145437-25f06f837f87 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this use the newer legacy?
i believe the proposal here ended up as part of #104 and this can be closed |
Continuing on #104. These two combined should match ipfs/boxo#322. Happy to have this PR closed and relevant changes made in #104, just needed a usable branch for testing.