Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gogo protobuf #4

Merged
merged 3 commits into from
Aug 7, 2018
Merged

update gogo protobuf #4

merged 3 commits into from
Aug 7, 2018

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Aug 7, 2018

This will allow us to address libp2p/go-libp2p-kad-dht#177 without forcing us to change the go APIs too much.

We've wanted to do this for a while anyways.

I've also stripped the tests from the gxed package (90% smaller).
This test fails if the protobuf file is regenerated.
@Stebalien
Copy link
Member Author

@whyrusleeping LGTY?

@whyrusleeping says 👌.

@Stebalien Stebalien merged commit 64bc844 into master Aug 7, 2018
@Stebalien Stebalien deleted the fix/upgrade-protobuf branch August 7, 2018 22:28
Jorropo pushed a commit to ipfs/boxo that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant