Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

ResolveToLastNode no longer fetches nodes it does not need #30

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

aschmahmann
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Aug 26, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the feeling there should be a way to rewrite the loop in a clearer way, but this makes sense anyways.

@aschmahmann aschmahmann force-pushed the fix/resolve-no-extra-lookups branch from 5cb05e7 to c6b0980 Compare August 26, 2020 18:02
@aschmahmann aschmahmann force-pushed the fix/resolve-no-extra-lookups branch from c6b0980 to 6d87ec0 Compare August 26, 2020 18:05
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but it could have unintended consequences. But the tests should cover it pretty well.

@aschmahmann aschmahmann merged commit 1533d95 into master Aug 26, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
…kups

ResolveToLastNode no longer fetches nodes it does not need

This commit was moved from ipfs/go-path@1533d95
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants