Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

chore: bump go version #32

Merged
merged 1 commit into from
Aug 26, 2020
Merged

chore: bump go version #32

merged 1 commit into from
Aug 26, 2020

Conversation

aschmahmann
Copy link
Contributor

No description provided.

aschmahmann
aschmahmann commented Aug 26, 2020
View reviewed changes
go.mod
Comment on lines +3 to +4
go 1.14

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any complaints with this bump? Supporting ancient go versions seems unnecessary.

@aschmahmann aschmahmann changed the base branch from ci/remove-gx to master August 26, 2020 17:34
@aschmahmann aschmahmann marked this pull request as ready for review August 26, 2020 17:34
@aschmahmann aschmahmann requested a review from Stebalien August 26, 2020 17:35
hsanjuan
hsanjuan approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might go with go1.15 already, though I'm not sure libp2p supports it yet.

@aschmahmann
Copy link
Contributor Author

I figure I'll wait a bit on 1.15. People cannot use go 1.15 with pre 0.7 versions of go-ipfs because of TLS changes.

@aschmahmann aschmahmann merged commit 1c1d3fc into master Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsanjuan hsanjuan hsanjuan approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aschmahmann @hsanjuan