This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
feat: LsBatchSync to fetch single batch of results #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
changed the title
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Nov 20, 2020
This adds --pin-count opt-in flag that returns number of 'queued/pinning/pinned/failed' pins at remote service or 'offline' if fetch of pin counts was not possible JSON representation uses PinCount object (missing when 'offline') Requires LsBatchSync from ipfs/go-pinning-service-http-client#4
aschmahmann
reviewed
Nov 30, 2020
aschmahmann
reviewed
Nov 30, 2020
aschmahmann
reviewed
Nov 30, 2020
aschmahmann
approved these changes
Nov 30, 2020
lidel
added a commit
that referenced
this pull request
Nov 30, 2020
|
@aschmahmann addressed your feedback, should be good now. |
This adds function that returns a single batch and an int with total count. This enables consumer of this lib to implement manual pagination or get total pin count in efficient manner.
Renaming to match naming convention in https://ipfs.github.io/pinning-services-api-spec/
aschmahmann
force-pushed
the
feat/ls-with-limit
branch
from
a866b68
to
b44dee1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds function that returns a single batch and an int with total count to indicate if more results match passed query.
ipfs pin remote service ls --pin-countin add remote pinning to ipfs command kubo#7661