This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Fix/handle overflow #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Dec 21, 2018
Stebalien
commented
- Fix an overflow where we can run out of hash bits.
- Keep all the hash bits even if we don't use them. I can't see a reason to use murmur64 over murmur128, murmur64 is just a truncated (non-standard) murmur128.
If we have a deep enough directory, we could walk off the end of the bit array.
1. It's less confusing. Murmur64 is something our library supports by truncating a Murmur128 hash. 2. We'll only use the part we need anyways. directory trees.
ghost
assigned 
whyrusleeping
approved these changes
Dec 21, 2018
hamt/hamt.go
Outdated
| idx := hv.Next(ds.tableSizeLg2) | ||
| idx, err := hv.Next(ds.tableSizeLg2) | ||
| if err != nil { | ||
| return fmt.Errorf("sharded directory too deep") |
There was a problem hiding this comment.
You're ignoring the returned error
There was a problem hiding this comment.
So, I returned a different error from hashBits.Next because, technically, it isn't specific to sharded directories. However, yeah, that probably wasn't worth the confusion (fixed).
schomatis
approved these changes
Dec 21, 2018
I didn't do this before because this datastructure *technically* isn't specific to sharded directories but, really, that was just even more confusing.
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 25, 2023
Fix/handle overflow This commit was moved from ipfs/go-unixfs@d7bb120
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.