feat(server): Helia Docker #1

whizzzkid · 2023-09-28T18:56:03Z

Testing instructions:

Make sure Docker 🐳 is running.
Build the image: docker build . --tag helia
Run the image: docker run -p 8080:8080 helia
Open browser: http://localhost:8080/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR
Try IPNS: http://localhost:8080/ipns/docs.ipfs.tech/how-to/run-ipfs-inside-docker/#set-up

Output:

ipns-resolve-helia.mov

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

SgtPooki

I don't see anything glaring, I'm good with this and had a few comments

package.json

SgtPooki · 2023-10-04T19:06:51Z

src/contentType.ts

+
+export const DEFAULT_MIME_TYPE = 'text/html'
+
+const tests: Array<(input: testInput) => testOutput> = [


Might be useful to abstract the content-type tests to a type/interface and use that.

SgtPooki · 2023-10-04T19:07:12Z

src/contentType.ts

+  // testing file-type from buffer
+  async ({ bytes }): testOutput => (await fileTypeFromBuffer(bytes))?.mime,
+  // testing file-type from path
+  // ts-expect-error


why expect error? add more info why this is needed?

mime.lookup complains about Unexpected value in conditional. A boolean expression is required.

SgtPooki · 2023-10-04T19:08:37Z

src/contentType.ts

+export async function parseContentType (input: testInput): Promise<string> {
+  let type = (await Promise.all(tests.map(async test => test(input)))).filter(Boolean)[0] as string


I feel like this is much harder to read than it needs to be. Also, we're always calling each of the type check fns (map), and then looping over all of the successful ones (filter), instead of returning quickly on the first success.

SgtPooki · 2023-10-04T19:11:48Z

src/heliaFetch.ts

+    const regex = /^\/(?<namespace>ip[fn]s)\/(?<address>[^/$]+)(?<relativePath>[^$]*)/
+    const result = path.match(regex)
+    if (result == null) {
+      throw new Error('Path is not valid, provide path as /ipfs/<cid> or /ipns/<path>')
+    }
+    return result.groups as { namespace: string, address: string, relativePath: string }


This is returning an error on a valid path:

http://localhost:8888/ipns/docs.ipfs.tech/how-to/run-ipfs-inside-docker/#set-up

see https://ipfs.io/ipns/docs.ipfs.tech/how-to/run-ipfs-inside-docker/#set-up

though I gave approval, this needs fixed (can be in later PR).

SgtPooki · 2023-10-04T19:15:44Z

src/heliaFetch.ts

+      const { Path } = await (await fetch(this.delegatedRoutingApi + address)).json()
+      this.ipnsResolutionCache.set(address, Path)
+    }
+    return this.fetch(`${this.ipnsResolutionCache.get(address)}${options?.path ?? ''}`)


this line is hard to follow tbh.

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

SgtPooki · 2023-10-04T20:06:54Z

src/contentType.ts

+export async function parseContentType (input: testInput): Promise<string> {
+  for (const test of tests) {
+    const type = await test(input)
+    if (type !== undefined) {
+      return overrideContentType(type)
+    }
+  }
+  return DEFAULT_MIME_TYPE
+}


Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

whizzzkid added 17 commits September 28, 2023 02:02

feat(helia): ✨ New HeliaFetch Impl

d1462db

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

feat: ✨ Serve helia fetch responses

feb6819

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

feat(helia): ✨ MimeTypes Work Correctly

6c76f6e

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

feat(helia): ✨ Adding GC route.

7d9aca7

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

feat(helia): ✨ IPNS Routing + Refactor

6f0353a

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

docs(helia):

b96bc79

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

fix(helia): 🚚 Routes

f0fa2bb

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

feat(helia): ✨ Helia Fetch IPNS

408c4fb

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

fix(helia): ➕ Adding Aegir

42f8acf

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

feat: ✨ Adding dockerfile.

dddcefe

fix: 🔧 Fix docker builds

4a41969

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

fix(helia): lint

1ab5ca0

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

feat(helia): 👷 Adding docker publish step.

26f328f

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

fix(helia): 🔧 Adding custom CMAKE flags

1db8748

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

fix: 👷 Fixing CI + Readme

450fd5a

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

fix: 🔧 flags

4ff18f5

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

fix: 🔧 Docker File

09c0d18

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

This was referenced Oct 4, 2023

Create infrastructure for testing and validating retrieval reliability with Helia ipfs/helia#275

Open

Gateway Measurements: Helia probe-lab/network-measurements#58

Open

whizzzkid added 2 commits October 4, 2023 02:18

feat(helia): ✨ Add version string.

8ce2220

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

fix: Cache in-memory Helia Version Info

1783c52

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

SgtPooki approved these changes Oct 4, 2023

View reviewed changes

whizzzkid and others added 3 commits October 4, 2023 13:31

Update package.json

8b8ad21

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>

Update package.json

16990d5

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>

fix: ✏️ Fixing PR comments.

c2e48f4

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

SgtPooki approved these changes Oct 4, 2023

View reviewed changes

whizzzkid added 3 commits October 4, 2023 14:26

fix(helia): 🐛 finding rootFile.

f10b667

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

fix(helia): 🐛 redirection bug caused mapping to be wrong.

530ea20

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

fix(helia): 🎨 Making this readable.

eabfe41

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

whizzzkid merged commit 13dd94b into main Oct 4, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(server): Helia Docker #1

feat(server): Helia Docker #1

whizzzkid commented Sep 28, 2023 •

edited

Loading

SgtPooki left a comment

SgtPooki Oct 4, 2023

SgtPooki Oct 4, 2023

whizzzkid Oct 4, 2023

SgtPooki Oct 4, 2023

whizzzkid Oct 4, 2023

SgtPooki Oct 4, 2023

SgtPooki Oct 4, 2023

whizzzkid Oct 4, 2023

SgtPooki Oct 4, 2023

whizzzkid Oct 4, 2023

SgtPooki Oct 4, 2023


		export const DEFAULT_MIME_TYPE = 'text/html'

		const tests: Array<(input: testInput) => testOutput> = [

		export async function parseContentType (input: testInput): Promise<string> {
		let type = (await Promise.all(tests.map(async test => test(input)))).filter(Boolean)[0] as string

feat(server): Helia Docker #1

feat(server): Helia Docker #1

Conversation

whizzzkid commented Sep 28, 2023 • edited Loading

SgtPooki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

whizzzkid commented Sep 28, 2023 •

edited

Loading