feat: use production level docker settings #26
Conversation
|
initial e2e failed: https://github.com/ipfs/helia-http-gateway/actions/runs/6621155514/job/17984736369?pr=26, restarting them. |
Dockerfile
Outdated
| COPY --from=builder /usr/lib/**/libcrypto*.so /usr/lib/ | ||
| COPY --from=builder /usr/lib/**/libssl*.so /usr/lib/ |
There was a problem hiding this comment.
| COPY --from=builder /usr/lib/**/libcrypto*.so /usr/lib/ | |
| COPY --from=builder /usr/lib/**/libssl*.so /usr/lib/ | |
| COPY --from=builder /usr/lib/**/libcrypto* /usr/lib/ | |
| COPY --from=builder /usr/lib/**/libssl* /usr/lib/ |
There was a problem hiding this comment.
there is more than just the individual *.so files needed. It would be better to nail this down more, but removing the .so seems to fix the issue.
Dockerfile
Outdated
| RUN npm run build | ||
|
|
||
| ENV NODE_ENV production | ||
| RUN npm prune --production |
There was a problem hiding this comment.
| RUN npm prune --production | |
| RUN npm prune --omit=dev |
Dockerfile
Outdated
| FROM node:20-slim as app | ||
| WORKDIR /app |
There was a problem hiding this comment.
| FROM node:20-slim as app | |
| WORKDIR /app | |
| FROM node:20-slim as app | |
| ENV NODE_ENV production | |
| WORKDIR /app |
This reverts commit 896a42d.
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
| @@ -1,14 +1,40 @@ | |||
| FROM node:20-slim | |||
| FROM node:20-slim as builder | |||
There was a problem hiding this comment.
I wonder if alpine images are going to be even smaller.
| COPY --from=builder /usr/lib/**/libcrypto* /usr/lib/ | ||
| COPY --from=builder /usr/lib/**/libssl* /usr/lib/ |
There was a problem hiding this comment.
I've been burned in the past while handling shared libs. Can we not:
flowchart
A[node:20-slim] -->|Install LibSSL| B(Base Image)
B --> C[Builder Image]
C --> |Build Assets| D(Built Image)
B --> E[App Image]
D --> |Copy Built Assets| E
E --> F(Publish)
There was a problem hiding this comment.
we can re-install libssl and it would re-use the cached image, but that was more troublesome due to some additional things being installed by other apt-get installed packges: build-essential cmake git libssl-dev and I didn't want to reinstall all of them.
| ENV NODE_ENV production | ||
| WORKDIR /app | ||
| # built src without dev dependencies | ||
| COPY --from=builder /app ./ |
There was a problem hiding this comment.
a further opportunity for improvement will be removing node_modules as it has devDependencies here, reinstalling with NODE_ENV=production (already set) would only install dependencies
Further reduction in image size.
There was a problem hiding this comment.
node_modules should be removed above in the npm prune --omit=dev line
btw its not just image size adjustments, but signal handling and other general best-practices (without me spending too much time on it: ~2hr) so that tiros (or whoever) can shut it down when they want to and it wont hang |
* main: (27 commits) feat(e2e): add /api/v0/repo/gc test chore: disable METRICS on CI e2e test runs test: add e2e test for /api/v0/version endpoint feat(server): ⚡️ Subdomain Gateway Using Fastify (#31) feat: use production level docker settings (#26) chore: remove unused playwright init code fix: use active LTS in package.json engines fix: playwright CI node-version=20 test: get clinic flame & doctor output from e2e tests test: e2e updates fix: use HOST constant in healthcheck fix: use HOST constant test: cleanup playwright test code test: add playwright tests feat: move HOST,PORT to src/constants.ts fix: ✏️ Fixing urls. (#23) fix: ✏️ helia-docker -> helia-http-gateway (#22) build(deps): Bump @babel/traverse and depcheck (#13) feat: add health-check (#21) fix(server): 🩹 Using sessionID as a fallback to requests where referer is missing. (#20) ... Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
For best practices, see:
Docker sizes:
main branch
from this PR