Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker container = helia-http-gateway #42

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: docker container = helia-http-gateway #42

merged 1 commit into from
Oct 30, 2023

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Oct 27, 2023 •
edited
Loading

  • fix: docker container name
$ docker image ls
REPOSITORY                                            TAG                IMAGE ID       CREATED              SIZE
helia-http-gateway                                    latest             beeb3fdc1eb3   About a minute ago   833MB
helia-http-gateway-helia-http-gateway                 latest             3448ec33a2fa   3 minutes ago        833MB
helia-docker-helia-http-gateway                       latest             f67603eb95d2   13 minutes ago       833MB

@SgtPooki
Copy link
Member Author

The published docker registry name is correct at https://github.com/ipfs/helia-http-gateway/actions/runs/6663471494/job/18109407517#step:6:1249 (last CI run on main), but should also be correct with this PR for published container name, and local names.

whizzzkid
whizzzkid reviewed Oct 30, 2023
View reviewed changes
docker-compose.yml

services:
helia-http-gateway:
http-gateway:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this will actually impact the publishing though.

@SgtPooki SgtPooki merged commit 97afc53 into main Oct 30, 2023
1 of 2 checks passed
@SgtPooki SgtPooki deleted the fix/docker-container-name branch October 30, 2023 16:20
@SgtPooki SgtPooki mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whizzzkid whizzzkid whizzzkid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtPooki @whizzzkid