Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use @helia/verified-fetch #63
feat: use @helia/verified-fetch #63
Changes from all commits
9a080cd
a27934d
b4c61e5
e9f47e5
1c781c4
daa4fed
893a320
3ad077f
a774085
d9d14e9
34afd73
7dc2af9
7933118
9e2e338
6564215
6312031
29c27d6
4597384
0630e45
a65e3f6
36b2226
4a7a253
a6b08bf
5509431
84455c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we couldn't just merge the
USE_BITSWAP
andUSE_LIBP2P
vars to just be use@helia/http
or usehelia
?Like,
USE_HTTP_GATEWAYS_ONLY
or something to select@helia/http
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm down with finagling the configs in another PR once we get verified-fetch in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to #65